Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitelist does not work when useIcons is true #664

Closed
romgere opened this issue Apr 1, 2021 · 1 comment · Fixed by #1029
Closed

whitelist does not work when useIcons is true #664

romgere opened this issue Apr 1, 2021 · 1 comment · Fixed by #1029
Labels
released

Comments

@romgere
Copy link

romgere commented Apr 1, 2021

In the _filterComponents method of index.js file whitelist entries are ignored if blacklist is not empty.

But the script automatically add uk-icon to blacklist if option useIcons is true. This behavior cause the whitelist to be ignored.
anehx added a commit to anehx/ember-uikit that referenced this issue Mar 29, 2023
@anehx
fix(build): fix disabling icons in combination with whitelist
887fb23 
Resolves adfinis#664
@anehx anehx mentioned this issue Mar 29, 2023
Merged
anehx added a commit that referenced this issue Mar 31, 2023
@anehx
fix(build): fix disabling icons in combination with whitelist
4b2406c 
Resolves #664
anehx pushed a commit that referenced this issue Mar 31, 2023
@semantic-release-bot
chore(release): 7.0.1 [skip ci]
dbb54ea 
## [7.0.1](v7.0.0...v7.0.1) (2023-03-31)

### Bug Fixes

* **build:** fix disabling icons in combination with whitelist ([4b2406c](4b2406c)), closes [#664](#664)
* **build:** make sure coverage plugin is only loaded in addon tests ([3b294eb](3b294eb))
* make sure needed dependencies are installed in the host app ([ce5c0dc](ce5c0dc)), closes [#963](#963)
@anehx
Copy link
Member

anehx commented Mar 31, 2023

🎉 This issue has been resolved in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@anehx anehx added the released label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): fix disabling icons in combination with whitelist anehx/ember-uikit
2 participants
@anehx @romgere