fix(linked-items): add href to linked tab and subnav items

adfinis · Jan 24, 2022 · 5340369 · 5340369
1 parent 24b34b8
commit 5340369
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/addon/components/-private/linked-list-item.hbs b/addon/components/-private/linked-list-item.hbs
@@ -5,5 +5,5 @@
   }}
   ...attributes
 >
-  <a href={{this.href}} {{on "click" this.navigate}}>{{yield}}</a>
+  <a href={{@href}} {{on "click" this.navigate}}>{{yield}}</a>
 </li>
diff --git a/tests/integration/components/uk-subnav/item-test.js b/tests/integration/components/uk-subnav/item-test.js
@@ -40,7 +40,7 @@ module("Integration | Component | uk subnav/item", function (hooks) {
   });
 
   test("can navigate via href", async function (assert) {
-    assert.expect(3);
+    assert.expect(4);
 
     this.owner.lookup("service:router").transitionTo = (href) => {
       assert.step("navigate");
@@ -49,6 +49,8 @@ module("Integration | Component | uk subnav/item", function (hooks) {
 
     await render(hbs`<UkSubnav::Item @href="/">Test</UkSubnav::Item>`);
 
+    assert.dom("a").hasAttribute("href", "/");
+
     await click("a");
 
     assert.verifySteps(["navigate"]);

diff --git a/tests/integration/components/uk-tab/item-test.js b/tests/integration/components/uk-tab/item-test.js
@@ -37,7 +37,7 @@ module("Integration | Component | uk tab/item", function (hooks) {
   });
 
   test("can navigate via href", async function (assert) {
-    assert.expect(3);
+    assert.expect(4);
 
     this.owner.lookup("service:router").transitionTo = (href) => {
       assert.step("navigate");
@@ -46,6 +46,8 @@ module("Integration | Component | uk tab/item", function (hooks) {
 
     await render(hbs`<UkTab::Item @href="/">Test</UkTab::Item>`);
 
+    assert.dom("a").hasAttribute("href", "/");
+
     await click("a");
 
     assert.verifySteps(["navigate"]);