Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise icarDurationType enum to use ISO8601 period syntax #518

Open
wants to merge 1 commit into
base: Develop
Choose a base branch
from
Open

Standardise icarDurationType enum to use ISO8601 period syntax #518

wants to merge 1 commit into from

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Feb 12, 2025

Change icarDurationType (used by the icarObservationSummaryResource statistics) to use ISO8601 periods.
These periods

  • Begin with the literal "P"
  • Optionally have a number of days, weeks, or months using "D", "W", or "M"
  • Optionally have a "T" separator for time
  • Optionally have a number of hours and minutes using "H", "M".

Resolves #517

@cookeac cookeac linked an issue Feb 12, 2025 that may be closed by this pull request
Standardise durations for observation summary metrics (months/minutes confusion) #517
Open
erwinspeybroeck
erwinspeybroeck approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@erwinspeybroeck erwinspeybroeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinspeybroeck erwinspeybroeck erwinspeybroeck approved these changes

@jdoemel jdoemel Awaiting requested review from jdoemel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise durations for observation summary metrics (months/minutes confusion)
2 participants
@cookeac @erwinspeybroeck