Add enum for milk characteristics type #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an enumeration for milk characteristics type.
icarMilkingVisitEventResourceandicarMilkCharacteristicsTypeare quite old and hard to understand.Ideally milking characteristics would be managed with a scheme and a published list of characteristics with documented values.
A fallback is to make this an enum. Even there, for a few edge cases, moving from a string to an enum (with a list of valid values) might be a breaking change. Therefore, we have created the enum file and are just referencing it from the description.
Resolves #444 (sort of).