Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis #41

Merged
merged 3 commits into from
Sep 15, 2023
Merged

redis #41

merged 3 commits into from
Sep 15, 2023

Conversation

jesusfcr
Copy link
Contributor

@jesusfcr jesusfcr commented Aug 7, 2023 •
edited
Loading

  • Upgrade redis to v9

Removed Pipeline.Close since there is no real need to explicitly manage pipeline resources and it can be safely reused via sync.Pool etc. Pipeline.Discard is still available if you want to reset commands for some reason.

  • Remove deprecated ioutil
  • Stop app after test

@jesusfcr jesusfcr enabled auto-merge (squash) September 14, 2023 14:30
manelmontilla
manelmontilla approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@manelmontilla manelmontilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusfcr jesusfcr merged commit f4f1e73 into master Sep 15, 2023
@jesusfcr jesusfcr deleted the redis branch September 15, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manelmontilla manelmontilla manelmontilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusfcr @manelmontilla