[BSU-0020] - Generic Async/Await Network Layer #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 9, 2023 16:28
…est' inside RequestSerializer extension
…ements the request method using async await
added 5 commits
January 12, 2023 16:33
…we do not get the error called 'T type could not be inferred'
…eleted to fix scheme build for testing error
…nly once with correct url and httpMethod
added 3 commits
January 12, 2023 23:31
…ctable, to shorten request method signature
bahaadesso
reviewed
Jan 12, 2023
There was a problem hiding this comment.
- We have BaseServiceProvider. We should also have WebServiceProvider for defining various services.
- Remote Data Source can be defined.
- Example Response, Repository can be defined.
- Authenticated request can be implemented later.
Pr can be improved but it works very well with an example api :)
bahaadesso
reviewed
Jan 12, 2023
BoilerPlateSwiftUITests/NetworkLayerTests/BaseServiceTests.swift
Outdated
Show resolved
Hide resolved
added 11 commits
January 13, 2023 12:40
…should be implemented, so I added a warning
…he 'prepareAuthenticatedRequest' method
…ds are already throws an error
added 5 commits
January 18, 2023 16:10
…it is the actual class making the network requests
mfsaglam
changed the title
…hat we do not need to check how many times 'dataForRequest' invoked
…test code and make it more readable
…oError' conforms to equatable so that we can compare the errors inside tests
… target as an extension, since it is for testing purposes only
…d, by returning a tuple (session, sut)
…JsonHelper for testing easiness
…revent any breaking changes in the future
# Conflicts: # BoilerPlateSwiftUI.xcodeproj/project.pbxproj
# Conflicts: # BoilerPlateSwiftUI.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.