Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use destructuring more and minor tweaks #57

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Use destructuring more and minor tweaks #57

merged 4 commits into from
Sep 12, 2023

Conversation

XhmikosR
Copy link
Collaborator

No description provided.

@XhmikosR XhmikosR marked this pull request as ready for review August 20, 2023 18:04
@XhmikosR XhmikosR requested a review from bezoerb August 20, 2023 18:04
index.js Show resolved Hide resolved
Co-authored-by: Ben Zörb <[email protected]>
@XhmikosR
Copy link
Collaborator Author

@bezoerb if you could also add a test so that we cover the undefined case that would be perfect :)

@bezoerb
Copy link
Collaborator

bezoerb commented Sep 2, 2023

@XhmikosR: just took a closer look and i think we don't need the || {} because as of my understanding it can't return undefined as we're only looping over the elements which have been previously selected.

I thought one might just pass an invalid type to the function but this is also already handled.

@bezoerb bezoerb self-requested a review September 2, 2023 21:48
@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Sep 3, 2023

I just reverted the fallback addition, can you confirm all is good?

@bezoerb bezoerb merged commit 5210b92 into master Sep 12, 2023
8 checks passed
@bezoerb bezoerb deleted the xmr/dev branch September 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants