add support for link preload hrefs #19
Conversation
| like : "" | ||
|
|
||
| } | ||
| }</script><script src="//platform.twitter.com/oct.js"></script><script>twttr.conversion.trackPid('l4mg5');</script><noscript><img height="1" width="1" style="display:none;" alt="" src="https://analytics.twitter.com/i/adsct?txn_id=l4mg5&p_id=Twitter" /> <img height="1" width="1" style="display:none;" alt="" src="//t.co/i/adsct?txn_id=l4mg5&p_id=Twitter" /></noscript></body></html> |
There was a problem hiding this comment.
I can't help but feel like this is a little OTT for a test page. Are we using this here for a specific reason? If not, would it be possible to simplify it down into something that doesn't rely on as much third-party content and scripts?
There was a problem hiding this comment.
Whoops, I think that is a copy pasta error, my mistake! I'll replace it with a smaller test file.
|
PR LGTM minus the test.html file used. @akrawchyk could you comment on that and we can work on getting this landed soon and chase up the PR in critical right after? |
| @@ -8,6 +8,7 @@ | |||
| <!-- Place favicon.ico and apple-touch-icon.png in the root directory --> | |||
| <link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.css" /> | |||
| <link rel="stylesheet" href="styles/main.css"> | |||
| <link rel="preload" href="styles/preload.css" as="style"> | |||
There was a problem hiding this comment.
@addyosmani in reference to https://github.com/addyosmani/oust/pull/19/files#r67332062, this is the only adjustment I made for the test. The test.html file was for my use case and wasn't meant to be committed.
This PR adds support for
preloadlinks as specified here https://w3c.github.io/preload/.