Correct the parameters in callback example #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code errors on the extra parenthesis in the 2nd callback param.
bezoerb
approved these changes
Jun 5, 2022
kodiakhq bot
referenced
this pull request
in roots/bud
Sep 21, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [critical](https://togithub.com/addyosmani/critical) | [`4.0.1` -> `5.0.2`](https://renovatebot.com/diffs/npm/critical/4.0.1/5.0.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [critical](https://togithub.com/addyosmani/critical) | [`^4.0.1` -> `^4.0.1 \|\| ^5.0.0`](https://renovatebot.com/diffs/npm/critical/4.0.1/5.0.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>addyosmani/critical</summary> ### [`v5.0.2`](https://togithub.com/addyosmani/critical/releases/tag/v5.0.2) [Compare Source](https://togithub.com/addyosmani/critical/compare/v5.0.1...v5.0.2) - bump dependencies ([#​544](https://togithub.com/addyosmani/critical/issues/544)) [`116b9c3`](https://togithub.com/addyosmani/critical/commit/116b9c3) ### [`v5.0.1`](https://togithub.com/addyosmani/critical/releases/tag/v5.0.1) [Compare Source](https://togithub.com/addyosmani/critical/compare/v5.0.0...v5.0.1) - adds missing exports in package.json [`80d6d26`](https://togithub.com/addyosmani/critical/commit/80d6d26) - Update README.md [`4749fb3`](https://togithub.com/addyosmani/critical/commit/4749fb3) ### [`v5.0.0`](https://togithub.com/addyosmani/critical/releases/tag/v5.0.0) [Compare Source](https://togithub.com/addyosmani/critical/compare/v4.0.1...v5.0.0) #### Breaking - Require Node.js 14.16 - This package is now pure ESM. Please [read this](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c). #### New Contributors - [@​dlubitz](https://togithub.com/dlubitz) made their first contribution in [https://github.com/addyosmani/critical/pull/512](https://togithub.com/addyosmani/critical/pull/512) - [@​kentr](https://togithub.com/kentr) made their first contribution in [https://github.com/addyosmani/critical/pull/537](https://togithub.com/addyosmani/critical/pull/537) **Full Changelog**: addyosmani/critical@v4.0.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 2am" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/roots/bud).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536.