added penthouse timeout option #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| stable | |||
|
One nit. Thanks |
| @@ -219,6 +222,7 @@ critical.generate({ | |||
| | inlineImages | `boolean` | `false` | Inline images | |||
| | assetPaths | `array` | `[]` | List of directories/urls where the inliner should start looking for assets | |||
| | maxImageFileSize | `integer` | `10240`| Sets a max file size (in bytes) for base64 inlined images | |||
| | timeout | `integer` | `30000`| Sets a maximum timeout for the operation | |||
There was a problem hiding this comment.
The column separators should be aligned with the others.
There was a problem hiding this comment.
friendly ping on this @leogdion
There was a problem hiding this comment.
done. let me know if there is anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times Penthouse times out. I allowed the ability to set the timeout used by Penthouse.