Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to media=print async CSS loading #444

Closed
Snugug opened this issue Apr 28, 2020 · 2 comments
Closed

Move to media=print async CSS loading #444

Snugug opened this issue Apr 28, 2020 · 2 comments

Comments

@Snugug
Copy link

Snugug commented Apr 28, 2020

Working off of Critical v2.0.0-24, I'm seeing async CSS links being rewritten to a preload based strategy presumably based on the loadCSS project, but it looks like the currently recommended code favors media="print" instead of preload, and in doing so improves browser support greatly.

I think it's be worthwhile to move Critical 2.x to this print based approach, maybe optionally allowing for a declarative property to include the preload option as described further down in that article.
@bezoerb
Copy link
Collaborator

bezoerb commented Apr 28, 2020

Hey @Snugug
thanks for this issue :)
The inlining is done by inline-critical so i will move the issue there.

@bezoerb bezoerb mentioned this issue Apr 28, 2020
Closed
bezoerb pushed a commit that referenced this issue May 24, 2020
Bump inline-critical (#444)
219cb8a
@bezoerb
Copy link
Collaborator

bezoerb commented May 24, 2020

fixed in v2.0.0-25

@bezoerb bezoerb closed this as completed May 24, 2020
@swissspidy swissspidy mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Snugug @bezoerb