Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Added support for Kafka in metrics3 and a sample config #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstump
Copy link

@mstump mstump commented Jul 7, 2017

This is a pull request for issue #47, adding Kafka as a configurable reporter.

@mstump mstump force-pushed the v3.0.3-kafka branch 3 times, most recently from a968764 to fd43c85 Compare July 7, 2017 21:58
Copy link
Contributor

@sio2boss sio2boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good other than the version of metrics-kafka

<dependency>
<groupId>com.github.mstump</groupId>
<artifactId>metrics-kafka</artifactId>
<version>c804bf1874</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you are planning a 0.0.1 release? mstump/metrics-kafka@47ff721

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'll cut a release tonight or tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants