Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Python3.8 Error when reading a file proposed fix #4

Merged
merged 3 commits into from
Apr 22, 2020
Merged

PR: Python3.8 Error when reading a file proposed fix #4

merged 3 commits into from
Apr 22, 2020

Conversation

FredHappyface
Copy link
Contributor

Fixes #3

Tasks

  • Fix _make_fn for python 3.8+ (pypdn.namedlist._make_fn())
  • Test namedList for python 3.8+ (tests.test_namedlist.test_repr_basic_py3_8)

Differences to proposed solution

  • This patch maintains python 2 compatibility
  • Respected source formatting (spaces and indent levels)

Any issues please let me know

addisonElliott
addisonElliott approved these changes Apr 22, 2020
View reviewed changes
Copy link
Owner

@addisonElliott addisonElliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I pulled it locally and tested it.

I made a minor change to your test case. Look it over and if you're good with it, I'll merge it.

FredHappyface
FredHappyface commented Apr 22, 2020
View reviewed changes
Copy link
Contributor Author

@FredHappyface FredHappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Yeah I guess the try except was unnecessarily verbose now I think about it.

@addisonElliott addisonElliott merged commit c43d6dc into addisonElliott:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addisonElliott addisonElliott addisonElliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python3.8 Error when reading a file proposed fix
2 participants
@FredHappyface @addisonElliott