-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRR: Replace Skimage with custom functions #8
Comments
Sure, I'd accept a PR if the skimage logic was relatively easy to implement in this library. I don't have many calls to skimage functions. |
That's great, I'll make a start |
@FredHappyface I appreciate the help for this library. Sorry for the delay on merging the branch. Would you like me to release a new version for this? Personally, I would prefer until more improvements are made but if you need it, then I can make an exception. |
@addisonElliott No worries at all! There's no rush. Would be great if you can but don't worry if you would prefer to bundle more stuff 😄 Glad I could be of help |
I have recently replaced Skimage with a few of my own functions in one of my libraries so I could make it work on python 3.5 (the most recent version requires python 3.6+). When looking at this further and then attempting to install pypdn for python 3.5+ I ran into the following trouble:
Installing matplotlib (3.0.3) caused trouble in a windows environment. This falls under Skimage. I was surprised to see the crazy amount of dependencies it required when I was only using about two functions:
The question is would you accept a pull request that would replace these functions to reduce the number of dependencies required? (Pull Request Request - or PRR)
Thanks 😄
The text was updated successfully, but these errors were encountered: