Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev files after build #38

Closed
develar opened this issue Jun 23, 2017 · 3 comments
Closed

Remove dev files after build #38

develar opened this issue Jun 23, 2017 · 3 comments
Labels

Comments

@develar
Copy link

develar commented Jun 23, 2017

Currently, prebuild binaries doesn't work for macOS. And it leads to electron-userland/electron-builder#1738

I have fixed this issue on electron-builder side to help users (develar/electron-builder@fe42d8e#diff-521d2ecafaba778a4744b243eee6a02cR135), but will cool if in the install script after build all files that not required for production, will be removed.

@addaleax addaleax added the build label Jun 25, 2017
@addaleax
Copy link
Owner

Currently, prebuild binaries doesn't work for macOS

That has been fixed, see #39. Is that sufficient to solve your problem in the majority of cases?

But yes, what you’re asking for seems to make sense.

@develar
Copy link
Author

develar commented Jun 26, 2017

s that sufficient to solve your problem in the majority of cases?

Electron can have own ABI version. Sorry, I cannot yet provide ABI version matrix.

addaleax added a commit that referenced this issue Jun 26, 2017
addaleax added a commit that referenced this issue Jun 26, 2017
@addaleax
Copy link
Owner

@develar Okay, I’ve published 3.0.0 with the build dir removed after install, and prebuilt binaries for Electron 1.6/1.7 on macOS and x64 Linux. Again, let me know if you have any trouble. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants