util: use faster -0 check

PR-URL: nodejs/node#15726 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
addaleax · Oct 4, 2017 · 44f845e · 44f845e
1 parent 3cfee3f
commit 44f845e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/benchmark/util/inspect.js b/benchmark/util/inspect.js
@@ -22,7 +22,8 @@ const bench = common.createBenchmark(main, {
     'Error',
     'Array',
     'TypedArray',
-    'TypedArray_extra'
+    'TypedArray_extra',
+    'Number'
   ],
   option: Object.keys(opts)
 });
@@ -92,6 +93,9 @@ function main({ method, n, option }) {
       obj[Symbol('baz')] = 5;
       benchmark(n, obj, options);
       break;
+    case 'Number':
+      benchmark(n, 0, options);
+      break;
     default:
       throw new Error(`Unsupported method "${method}"`);
   }

diff --git a/lib/util.js b/lib/util.js
@@ -615,8 +615,10 @@ function formatValue(ctx, value, recurseTimes, ln) {
 }
 
 function formatNumber(fn, value) {
-  // Format -0 as '-0'. Strict equality won't distinguish 0 from -0.
-  if (Object.is(value, -0))
+  // Format -0 as '-0'. A `value === -0` check won't distinguish 0 from -0.
+  // Using a division check is currently faster than `Object.is(value, -0)`
+  // as of V8 6.1.
+  if (1 / value === -Infinity)
     return fn('-0', 'number');
   return fn(`${value}`, 'number');
 }