Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rowIdx to CellClickArgs #3645

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add rowIdx to CellClickArgs #3645

merged 2 commits into from
Nov 22, 2024

Conversation

amanmahajan7
Copy link
Contributor

Fixes #3611

@amanmahajan7 amanmahajan7 self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.39%. Comparing base (a0ba5fa) to head (03a8dad).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Cell.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3645      +/-   ##
==========================================
+ Coverage   90.13%   90.39%   +0.26%     
==========================================
  Files          48       48              
  Lines        3455     3455              
  Branches      670      656      -14     
==========================================
+ Hits         3114     3123       +9     
+ Misses        341      332       -9     
Files with missing lines Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/Cell.tsx 96.15% <66.66%> (+3.84%) ⬆️

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 22, 2024 21:46
@amanmahajan7 amanmahajan7 merged commit 3e8fe45 into main Nov 22, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-pass-rowidx branch November 22, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event like onRowClick and getting the index of the clicked row
2 participants