Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass column in onColumnResize #3644

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Pass column in onColumnResize #3644

merged 2 commits into from
Nov 22, 2024

Conversation

amanmahajan7
Copy link
Contributor

Fixes #3331

@amanmahajan7 amanmahajan7 self-assigned this Nov 22, 2024
@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 22, 2024 20:10
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (041357f) to head (093a4bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3644      +/-   ##
==========================================
- Coverage   91.31%   89.89%   -1.42%     
==========================================
  Files          48       48              
  Lines        3455     3455              
  Branches      671      663       -8     
==========================================
- Hits         3155     3106      -49     
- Misses        300      349      +49     
Files with missing lines Coverage Δ
src/DataGrid.tsx 87.55% <ø> (+2.07%) ⬆️
src/hooks/useColumnWidths.ts 95.50% <100.00%> (ø)

... and 10 files with indirect coverage changes

---- 🚨 Try these New Features:

@nstepien
Copy link
Contributor

Should update the readme

@amanmahajan7
Copy link
Contributor Author

Should update the readme
Gonna update docs once the PRs are merged

@amanmahajan7 amanmahajan7 merged commit a0ba5fa into main Nov 22, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-tweak-column-resize branch November 22, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to have column in OnColumnResizeCallback
2 participants