Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #3639

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Fix flaky tests #3639

merged 9 commits into from
Nov 20, 2024

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Nov 20, 2024

These tests fail almost everytime

@amanmahajan7 amanmahajan7 self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (69f29e9) to head (bee26f3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
- Coverage   91.60%   89.45%   -2.15%     
==========================================
  Files          48       48              
  Lines        3453     3453              
  Branches      684      651      -33     
==========================================
- Hits         3163     3089      -74     
- Misses        290      364      +74     

see 12 files with indirect coverage changes

---- 🚨 Try these New Features:

@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 20, 2024 14:13
nstepien
nstepien previously approved these changes Nov 20, 2024
vitest.workspace.ts Outdated Show resolved Hide resolved
Base automatically changed from am-rename-utils to main November 20, 2024 18:47
@amanmahajan7 amanmahajan7 dismissed nstepien’s stale review November 20, 2024 18:47

The base branch was changed.

@amanmahajan7 amanmahajan7 merged commit a606cdd into main Nov 20, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-fix-drag-fill-tests branch November 20, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants