Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename utils #3638

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Rename utils #3638

merged 6 commits into from
Nov 20, 2024

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Nov 19, 2024

Rename utils

get* -> get*Old
get*New -> get*

Also, updated a few tests to use the new utils

@amanmahajan7 amanmahajan7 self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (69f29e9) to head (2db06ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
+ Coverage   91.60%   91.68%   +0.08%     
==========================================
  Files          48       48              
  Lines        3453     3453              
  Branches      684      677       -7     
==========================================
+ Hits         3163     3166       +3     
+ Misses        290      287       -3     

see 13 files with indirect coverage changes

---- 🚨 Try these New Features:

@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 20, 2024 00:21
@amanmahajan7 amanmahajan7 merged commit ea34ae9 into main Nov 20, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-rename-utils branch November 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants