Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-readonly to readonly cells #2379

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Add aria-readonly to readonly cells #2379

merged 2 commits into from
Apr 27, 2021

Conversation

amanmahajan7
Copy link
Contributor

https://www.w3.org/TR/wai-aria-practices-1.2/#grid_roles_states_props

If the grid provides content editing functionality and contains cells that may have edit capabilities disabled in certain conditions, aria-readonly may be set true on cells where editing is disabled. If edit functions are disabled for all cells, aria-readonly may be set true on the grid element. Grids that do not provide editing functions do not include the aria-readonly attribute on any of their elements.

@amanmahajan7 amanmahajan7 self-assigned this Apr 27, 2021
src/Cell.tsx Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Stepien <[email protected]>
@amanmahajan7 amanmahajan7 merged commit be8cd4a into canary Apr 27, 2021
@amanmahajan7 amanmahajan7 deleted the am-aria-readonly branch April 27, 2021 13:45
gernotkogler pushed a commit to Garaio-REM/react-data-grid that referenced this pull request May 13, 2021
* Add aria-readonly

* Update src/Cell.tsx

Co-authored-by: Nicolas Stepien <[email protected]>

Co-authored-by: Nicolas Stepien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants