Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new jsx runtime, bump peerDeps #2184

Merged
merged 17 commits into from
Nov 9, 2020
Merged

Use the new jsx runtime, bump peerDeps #2184

merged 17 commits into from
Nov 9, 2020

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Oct 22, 2020

@nstepien nstepien self-assigned this Oct 22, 2020
tsconfig.json Outdated
@@ -4,7 +4,7 @@
"declaration": true,
"forceConsistentCasingInFileNames": true,
"inlineSources": true,
"jsx": "react",
"jsx": "react-jsx",
Copy link
Contributor Author

@nstepien nstepien Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we support the exports field in package.json, we could have a prod bundle using react-jsx, and dev bundle using react-jsxdev. 🤔

@nstepien nstepien changed the title TypeScript 4.1, use the new jsx runtime Use the new jsx runtime, bump peerDeps Nov 9, 2020
@nstepien nstepien marked this pull request as ready for review November 9, 2020 20:32
@nstepien nstepien merged commit 5d75c6a into canary Nov 9, 2020
@nstepien nstepien deleted the newjsx branch November 9, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants