Fix cell focusing logic #1352
Merged
Fix cell focusing logic #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focus the selection mask instead of parent node
nstepien
approved these changes
Oct 31, 2018
malonecj
approved these changes
Oct 31, 2018
malonecj
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Remove the hack to preserve scroll position Focus the selection mask instead of parent node * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a cell is selected, the scroll position is preserved before the focus and reapplied after the cell is focused. This is unnecessary and can cause janky behavior. The correct way is to focus on the
SelectionMaskelement instead of the container element.Thanks to @MayhemYDG for the tip.