ignore server port change, ignore server state outside vscode #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
reviewed
Jan 23, 2018
src/Constants.ts
Outdated
| @@ -22,3 +22,9 @@ export enum ServerState { | |||
| RunningServer = 'runningserver', | |||
| IdleServer = 'idleserver' | |||
| } | |||
|
|
|||
| export enum Port { | |||
There was a problem hiding this comment.
how about renaming it to : PortKind
jdneo
reviewed
Jan 23, 2018
src/Tomcat/TomcatController.ts
Outdated
| private disposeResource(resource: vscode.Disposable | undefined): void { | ||
| if (resource) { | ||
| resource.dispose(); | ||
| private disposeResources(resources: vscode.Disposable[]): void { |
There was a problem hiding this comment.
since this method only has one argument, how about making it as an open-ended function arguments:
private disposeResources(...resources: vscode.Disposable[])then no need to wrap arguments in [] when calling it
jdneo
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.