fix issue: check if server already stopped when stop server #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adashen
reviewed
Jan 11, 2018
| const server: TomcatServer = await getTargetServer(tomcat, tomcatItem, true); | ||
| if (server) { | ||
| if(server.isStarted()) { |
There was a problem hiding this comment.
In the previous version. If the server is already started, it will stop and start, so no need for the information here.
There was a problem hiding this comment.
I will suggest that we make a restart command to silently stop then start a running server.
adashen
reviewed
Jan 11, 2018
src/extension.ts
Outdated
| const server: TomcatServer = await getTargetServer(tomcat, tomcatItem); | ||
| if (server) { | ||
| if (!server.isStarted()) { | ||
| vscode.window.showInformationMessage('This Tomcat Server was stopped.'); |
There was a problem hiding this comment.
Should this message also in the Dialogmessage constants?
There was a problem hiding this comment.
yes, but that PR is in review, so just use pure string here.
andxu
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.