fix(accordion): undefined discriminated union typeguard (#187)

adaptui · Dec 14, 2020 · b234e3a · b234e3a · vercel · Dec 14, 2020
1 parent 8f5cbba
commit b234e3a
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/accordion/AccordionState.ts b/src/accordion/AccordionState.ts
@@ -42,12 +42,18 @@ export function useAccordionState(
   let selectedIdProp;
   let defaultSelectedId;
   let onSelectedIdChange;
-  if (props.allowMultiple === false || !props.allowMultiple) {
-    // @ts-ignore
+
+  // @see https://github.com/microsoft/TypeScript/issues/12184
+  // @see https://stackoverflow.com/a/61181442/10629172
+  function isUndefinedDiscrimination(
+    props: AccordionInitialStateSingle | AccordionInitialStateMulti,
+  ): props is AccordionInitialStateSingle {
+    return props.allowMultiple === false || props.allowMultiple === undefined;
+  }
+
+  if (isUndefinedDiscrimination(props)) {
     selectedIdProp = props.selectedId;
-    // @ts-ignore
     defaultSelectedId = props.defaultSelectedId || null;
-    // @ts-ignore
     onSelectedIdChange = props.onSelectedIdChange;
   }