Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow tracking ids without spoor installed (fixes #3464) #3465

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix: Allow tracking ids without spoor installed (fixes #3464) #3465

merged 1 commit into from
Sep 28, 2023

Conversation

oliverfoster
Copy link
Member

fixes #3464

Fix

  • Allow tracking ids without spoor installed

@oliverfoster oliverfoster self-assigned this Sep 20, 2023
joe-allen-89
joe-allen-89 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster mentioned this pull request Sep 27, 2023
Closed
@cahirodoherty-learningpool cahirodoherty-learningpool merged commit e8e2f15 into master Sep 28, 2023
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@semantic-release-bot
Chore(release): 5.32.2 [skip ci]
0da0411 
## [5.32.2](v5.32.1...v5.32.2) (2023-09-28)

### Fix

* Allow tracking ids without spoor installed (fixes #3464) (#3465) ([e8e2f15](e8e2f15)), closes [#3464](#3464) [#3465](#3465)
@github-actions
Copy link

🎉 This PR is included in version 5.32.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielghost danielghost danielghost approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking ids do not get added if spoor is not installed
4 participants
@oliverfoster @danielghost @cahirodoherty-learningpool @joe-allen-89