Fix for issue/1873 #2268
Merged
Fix for issue/1873 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
approved these changes
Nov 12, 2018
brian-learningpool
approved these changes
Nov 12, 2018
moloko
reviewed
Nov 12, 2018
src/core/js/libraries/inview.js
Outdated
| if (cssHidden) return true; | ||
|
|
||
| var style = window.getComputedStyle(element, null); | ||
| cssHidden = (style.display == "none" || style.visibility == "hidden"); |
There was a problem hiding this comment.
good opportunity to switch to strict equality checks here and on L570?
tomgreenfield
requested changes
Nov 12, 2018
|
@tomgreenfield sorry thought the last two commits on master to inview had removed IE8 support. Should have tested it... which I have now done ;-) |
oliverfoster
approved these changes
Nov 12, 2018
moloko
reviewed
Nov 12, 2018
src/core/js/libraries/inview.js
Outdated
| @@ -570,8 +570,7 @@ | |||
| var cssHidden = (element.style.display == "none" || element.style.visibility == "hidden"); | |||
| if (cssHidden) return true; | |||
|
|
|||
| var style = window.getComputedStyle(element, null); | |||
| cssHidden = (style.display == "none" || style.visibility == "hidden"); | |||
| cssHidden = $(element).css("display") === "none" || $(element).css("visibility") === "hidden"; | |||
There was a problem hiding this comment.
worth caching $(element)? or am I just being too picky?
moloko
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1873