-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed _allowScrollOver setting used for legacy browsers that would pause javascript on scroll #2054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this also need doing in https://github.com/adaptlearning/jquery.onscreen ?
if possible, could you do 'housekeeping' stuff like removing trailing spaces in a separate commit? it's a lot easier to focus on the actual changes you're making if they've got a commit of their own!
Yes it does need a separate pr to https://github.com/adaptlearning/jquery.onscreen also, which'll need to have a bump in the release date at the top of the file. These also need removing: |
@jamesrea83 any update on this one? |
src/core/js/app.js
Outdated
&& Adapt.articles.models.length > 0 | ||
&& Adapt.blocks.models.length > 0 | ||
&& Adapt.components.models.length > 0 | ||
&& Adapt.course.get('_id')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore the positions of the &&
s as per this commit.
No description provided.