Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed _allowScrollOver setting used for legacy browsers that would pause javascript on scroll #2054

Merged
merged 7 commits into from
Jun 28, 2018

Conversation

jamesrea83
Copy link
Member

No description provided.

Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also need doing in https://github.com/adaptlearning/jquery.onscreen ?

if possible, could you do 'housekeeping' stuff like removing trailing spaces in a separate commit? it's a lot easier to focus on the actual changes you're making if they've got a commit of their own!

@jamesrea83
Copy link
Member Author

@oliverfoster
Copy link
Member

@moloko
Copy link
Contributor

moloko commented Jun 5, 2018

@jamesrea83 any update on this one?

&& Adapt.articles.models.length > 0
&& Adapt.blocks.models.length > 0
&& Adapt.components.models.length > 0
&& Adapt.course.get('_id')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the positions of the &&s as per this commit.

@moloko moloko merged commit 3959609 into adaptlearning:master Jun 28, 2018
@moloko moloko changed the title removed legacy fix which paused javascript on scroll removed _allowScrollOver setting used for legacy browsers that would pause javascript on scroll Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants