issue/1523: added xapi model state functions #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloko
reviewed
Apr 11, 2017
src/core/js/models/componentModel.js
Outdated
| }, | ||
|
|
||
| triggerState: function() { | ||
| Adapt.tirgger("state:change", this.getState()); |
oliverfoster
changed the title
| result = []; | ||
| break; | ||
| case "object": | ||
| retuls = {}; |
| result = []; | ||
| break; | ||
| case "object": | ||
| retuls = {}; |
| // Unset waiting flag | ||
| this.triggerTrackableState.isQueued = false; | ||
|
|
||
| }, this), 17) |
There was a problem hiding this comment.
The 17 here is a magic number. Also, why 17?
There was a problem hiding this comment.
60fps ish. anywhere between 17ms and 40ms is usually good for stuff like this (25-60fps).
a defer would probably suffice but i wanted to group as many model changes as i could into one trigger, these numbers allow for a few short asynchronous model changes to occur before a callback without it seeming too laggy. > 250ms is probably too laggy (4 fps)
brian-learningpool
approved these changes
Sep 13, 2017
moloko
approved these changes
Sep 13, 2017
tomgreenfield
approved these changes
Oct 3, 2017
src/core/js/models/adaptModel.js
Outdated
| var trackable = _.result(this, 'trackable', []); | ||
| if (!_.keys(model.changed).find(function(item, index) { | ||
| return _.contains(trackable, item); | ||
| })) return; |
There was a problem hiding this comment.
This is quite difficult to read. Could we change to something like:
var isTrackable = _.keys(model.changed).find(function(item, index) {
return _.contains(_.result(this, 'trackable', []), item);
}.bind(this));
if (isTrackable) {
this.triggerTrackableState();
}❓
src/core/js/models/adaptModel.js
Outdated
|
|
||
| // Skip if trigger queued or adapt hasn't started yet | ||
| if (this.triggerTrackableState.isQueued || !Adapt.attributes._isStarted) { | ||
| return |
moloko
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #1523