Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1438: added backbone.controller #1439

Merged
merged 5 commits into from
Mar 9, 2017
Merged

issue-1438: added backbone.controller #1439

merged 5 commits into from
Mar 9, 2017

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 28, 2017 •
edited
Loading

Make code clearer by having a Backbone class for Controllers:

fixes issue: #1438

added backbone.controller from https://github.com/cgkineo/backbone.controller

@oliverfoster oliverfoster self-assigned this Feb 28, 2017
@oliverfoster oliverfoster changed the title Added backbone.controller issue-1438: added backbone.controller Feb 28, 2017
moloko
moloko suggested changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test this in a course with accessibility activated I get the error TypeError: Accessibility.$accessibilityInstructions is undefined originated from L448 of accessibility.js

@moloko
Copy link
Contributor

moloko commented Mar 1, 2017

Tested in Firefox with accessibility on, also quick SCORM test via the test harness and quick check of start controller by setting start page to co-05

@moloko
Copy link
Contributor

moloko commented Mar 1, 2017

did a very quick check in IE11 too

@oliverfoster
Copy link
Member Author

Ta :) much appreciated.

@oliverfoster
Copy link
Member Author

oliverfoster commented Mar 9, 2017 •
edited
Loading

@moloko would you mind re-reviewing? was just the BUTTON_STATE.SHOW_CORRECT_ANSWER to _buttons['_showCorrectAnswer'].text and _buttons['_showCorrectAnswer'].ariaLabel conversion
wrong pr

@oliverfoster
Copy link
Member Author

oliverfoster commented Mar 9, 2017 •
edited
Loading

@moloko would you mind re-reviewing, was just merge fixes for the BUTTON_STATE conflict on logging.js

@oliverfoster oliverfoster merged commit 225c7fa into master Mar 9, 2017
@tomgreenfield tomgreenfield deleted the issue/1438 branch May 18, 2017 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@moloko moloko moloko approved these changes

@lc-thomasberger lc-thomasberger lc-thomasberger approved these changes

Assignees

@oliverfoster oliverfoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @moloko @tomgreenfield @lc-thomasberger