Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In router.js, navigateToParent() does not check _canNavigate #961

Closed
brian-learningpool opened this issue Feb 18, 2016 · 3 comments
Closed

In router.js, navigateToParent() does not check _canNavigate #961

brian-learningpool opened this issue Feb 18, 2016 · 3 comments
Labels
bug
Milestone
v2.0.8

Comments

@brian-learningpool
Copy link
Member

This is inconsistent with the other navigation functions.
@oliverfoster
Copy link
Member

have you got this or did you want me to do it quick?

@brian-learningpool
Copy link
Member Author

I got this.

@oliverfoster
Copy link
Member

lovely

brian-learningpool added a commit that referenced this issue Feb 18, 2016
@brian-learningpool
Merge pull request #962 from adaptlearning/issue/961
52253f0 
Resolves #961, adds check on _canNavigate to navigateToParent()
@moloko moloko added this to the v2.0.8 milestone Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.0.8
Development

No branches or pull requests
3 participants
@moloko @brian-learningpool @oliverfoster