Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemsComponentModel has obtuse implementation #2071

Closed
oliverfoster opened this issue May 22, 2018 · 1 comment
Closed

ItemsComponentModel has obtuse implementation #2071

oliverfoster opened this issue May 22, 2018 · 1 comment
Assignees
Labels

Comments

@oliverfoster
Copy link
Member

Subject of the issue/enhancement/features

The way the ItemsComponentModel is written with regards to _items breaks backward compatibility with existing functionality unnecessarily.
_items is replaced by a Collection of Models which makes any existing code relying on _items being an array of objects stop working at this line
toJSON is then overridden to compensate, at this line

Expected behaviour

_items should return an array of objects.
_children should represent the collection, as with the other models.

@moloko
Copy link
Contributor

moloko commented Jun 26, 2018

I think this is all done now?

@moloko moloko closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants