Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition with drawerView #1817

Closed
brian-learningpool opened this issue Sep 29, 2017 · 0 comments
Closed

Race condition with drawerView #1817

brian-learningpool opened this issue Sep 29, 2017 · 0 comments
Assignees
Labels

Comments

@brian-learningpool
Copy link
Member

brian-learningpool commented Sep 29, 2017

This sometimes causes the drawer button to be visible even if there are no drawer items.

The reason for this is because drawerView is instantiated before navigationView. The logic (here), which checks whether the button should be displayed or not, does not find the button in the DOM.

This is because the view is created on app:dataReady rather than adapt:start.

@brian-learningpool brian-learningpool self-assigned this Sep 29, 2017
brian-learningpool added a commit that referenced this issue Sep 29, 2017
The init() function now listens out for adapt:start rather than app:dataReady.
brian-learningpool added a commit that referenced this issue Sep 29, 2017
The init() function now listens out for adapt:start rather than app:dataReady.
brian-learningpool added a commit that referenced this issue Sep 29, 2017
The init() function now listens out for adapt:start rather than app:dataReady.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant