Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt-contrib-matching: it's possible to open all the options at once #1541

Closed
moloko opened this issue Apr 25, 2017 · 0 comments · Fixed by #1542
Closed

adapt-contrib-matching: it's possible to open all the options at once #1541

moloko opened this issue Apr 25, 2017 · 0 comments · Fixed by #1542
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Apr 25, 2017

leading to this rather messy layout:
2017-04-25 15_57_04-adapt version 2 0 demonstration _ question components

Before we updated to select2, this used to work fine i.e. it was only possible to have one <select> control open at a time
@moloko moloko self-assigned this Apr 25, 2017
moloko added a commit that referenced this issue Apr 25, 2017
@moloko
remove the call to event.stopPropagation
d0cbb32 
as it is preventing the select2 library used by adapt-contrib-matching from making sure only one `<select>` control can be open at once - fixes #1541
@moloko moloko mentioned this issue Apr 25, 2017
Merged
oliverfoster pushed a commit that referenced this issue Apr 26, 2017
@moloko @oliverfoster
remove the call to event.stopPropagation (#1542)
0c308c5 
as it is preventing the select2 library used by adapt-contrib-matching from making sure only one `<select>` control can be open at once - fixes #1541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove the call to event.stopPropagation adaptlearning/adapt_framework
1 participant
@moloko