Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double call to app:dataLoaded #1532

Closed
oliverfoster opened this issue Apr 20, 2017 · 3 comments
Closed

double call to app:dataLoaded #1532

oliverfoster opened this issue Apr 20, 2017 · 3 comments
Assignees

Comments

@oliverfoster
Copy link
Member

https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/app.js#L75-L87

@chris-steele was this intentional? you did it with the async code and it went by unnoticed. i'll remove if not.

@chris-steele
Copy link
Contributor

How odd, yeah looks like the first instance can be removed as there's not much use having the event triggered prior to models being assigned to their collections.

@oliverfoster
Copy link
Member Author

oliverfoster commented Apr 20, 2017

Aight. I'll remove them both in turn and see what's what. Off hand I'd say the second should be removed to keep the behaviour consistent with its prior state. I'll see what it breaks and post and update. 👍

@moloko
Copy link
Contributor

moloko commented May 15, 2017

@chris-steele @oliverfoster just to remind you that one of you still needs to sort this out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants