Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging module: when logging to the console, use the matching console functions if available #1444

Closed
moloko opened this issue Mar 1, 2017 · 4 comments
Closed

logging module: when logging to the console, use the matching console functions if available #1444

moloko opened this issue Mar 1, 2017 · 4 comments
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Mar 1, 2017

since many of the browser developer tools consoles support .info, .warn and .error methods on the console object, it would be good to redirect to these rather than just using console.log all the time.

In particular, messages logged via console.error allow for the stack trace to be shown - so is currently is more useful than simply doing Adapt.log.error.
@oliverfoster
Copy link
Member

+1

@moloko
Copy link
Contributor Author

moloko commented Mar 7, 2017

@oliverfoster also could be worth taking a look at this as there's some useful looking stuff in there

@oliverfoster
Copy link
Member

nice, ta 👍

@moloko moloko self-assigned this Jun 24, 2017
moloko added a commit that referenced this issue Jul 24, 2017
@moloko
Merge pull request #1612 from adaptlearning/feature/#1444
d383e75 
amends logging module to use matching methods of the console object
@moloko
Copy link
Contributor Author

moloko commented Jul 24, 2017

done in d383e75

@moloko moloko closed this as completed Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @oliverfoster