Issue/788 #801
Merged
Issue/788 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enabled via a CKEditor config on initialisation.
This features the addition of the lib/bowermanager.js helper, and moving the bower management to core. Further re-work is required to remove old, redundant code.
The 'build' folder was automatically added in v1.x of the Adapt framework but is not in v2.x. This change should allow backwards compatibility.
| @@ -362,7 +362,7 @@ Origin.prototype.createServer = function (options, cb) { | |||
| }, configuration.getConfig('dbName')); | |||
| }; | |||
|
|
|||
| Origin.prototype.startServer = function () { | |||
| Origin.prototype.startServer = function (options) { | |||
There was a problem hiding this comment.
options should be checked, and defaulted if not passed:
options = 'undefined' === typeof options ? { skipVersionCheck: false } : options;
or similar
- Swapped console.log() calls for logger.log() - Moved defaulting the 'options' object to startServer()
This was referenced Sep 3, 2015
|
+1 - all tested and worked with my courses. Although I reckon running npm install for the user would be a nice addition |
|
There's a separate issue for that here #804. ;) |
|
+1 works for me |
In course.json: - customStyle - tags - heroImage In components.json: - _componentType While looking into this it was noticed that the editorOnly property did not work with arrays/array items -- that is now fixed.
|
+1 tested and working. nice one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for refreshing core plugins as part of the upgrade.