-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append build folder to output #740
Conversation
@@ -33,7 +33,9 @@ AdaptOutput.prototype.publish = function (courseId, isPreview, request, response | |||
tenantId = user.tenant._id, | |||
outputJson = {}, | |||
isRebuildRequired = false, | |||
// should this be Constants.Defaults.ThemeName? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're correct.
Hey Tom - I think this is required for Framework 2.0 integration, right? Can you link an issue and update the description? Thanks. |
Cool, I'll sort that now. Another minor question: I've appended the build folder to the output, but is this actually needed? it doesn't look like anything else goes in there atm? |
I don't think the build folder should be appended to the output, unless something else has changed in the framework? |
+1 |
1 similar comment
+1 |
Append build folder to output
Fixes: #735