Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/#632 #648

Merged
merged 4 commits into from
May 13, 2015
Merged

Issue/#632 #648

merged 4 commits into from
May 13, 2015

Conversation

finbartracey1
Copy link
Contributor

ref: #634

@finbartracey1
issue/#632
d3a4768 
desc: update application.js to allow the use of express middleware by plugins
@finbartracey1
issue/#632
535d090 
desc: fixed indentation.
@finbartracey1
issue/#632
977465a 
desc: replaced asyn with foreach and added logging on exception error
@finbartracey1
issue/#532
c4fbb27 
desc: change better regulate middleware introduced by plugins
@dennis-learningpool
Copy link
Member

+1

@brian-learningpool
Copy link
Member

+1, although a hook based approach might make more sense.

brian-learningpool added a commit that referenced this pull request May 13, 2015
@brian-learningpool
Merge pull request #648 from adaptlearning/issue/#632
3c394b8 
Issue/#632
@brian-learningpool brian-learningpool merged commit 3c394b8 into develop May 13, 2015
@brian-learningpool brian-learningpool deleted the issue/#632 branch May 13, 2015 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finbartracey1 @dennis-learningpool @brian-learningpool