Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use aria-disabled instead of disabled on input (fixes #183) #184

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix: Use aria-disabled instead of disabled on input (fixes #183) #184

merged 1 commit into from
Oct 14, 2024

Conversation

oliverfoster
Copy link
Member

fixes #183

Fix

  • Allow screen reader to read aria labels on items when items are disabled

@oliverfoster oliverfoster self-assigned this Oct 8, 2024
@oliverfoster oliverfoster marked this pull request as ready for review October 8, 2024 10:02
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 8, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Tested with VoiceOver in Safari on Mac.

@kirsty-hames kirsty-hames merged commit 6504e5f into master Oct 14, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/183 branch October 14, 2024 11:07
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
@semantic-release-bot
Chore(release): 7.6.1 [skip ci]
51c1f82 
## [7.6.1](v7.6.0...v7.6.1) (2024-10-14)

### Fix

* Use aria-disabled instead of disabled on input (fixes #183) (#184) ([6504e5f](6504e5f)), closes [#183](#183) [#184](#184)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use aria-disabled on items such that the screen reader can read when disabled
4 participants
@oliverfoster @kirsty-hames @cahirodoherty-learningpool @ethan-lp