Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add default values for Drawer button icon and position (fixes #534) #536

Merged
merged 4 commits into from
May 15, 2024
Merged

Fix: Add default values for Drawer button icon and position (fixes #534) #536

merged 4 commits into from
May 15, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 13, 2024 •
edited
Loading

Fixes #534

Note: This PR is considered a stopgap until #512 is completed.

Fix

Sets defaults for the Drawer navigation button:

  • Set a default icon of icon-list for the _iconClass property. The icon will no longer be hidden if _iconClass is not set.
  • Set a default _position of auto

Testing

In config.json, configure the _drawer object with and without values for _iconClass and _position. When not set, it should show the list icon and the position should be auto.

list-icon 
  "_drawer": {
    "_showEasing": "easeOutQuart",
    "_hideEasing": "easeInQuart",
    "_duration": 400,
    "_position": "right",
    "_iconClass": "icon-folder"
  },

@swashbuck swashbuck self-assigned this May 13, 2024
@swashbuck swashbuck added the bug Something isn't working label May 13, 2024
@swashbuck swashbuck changed the title Fix: Show default icon for the Drawer navigation button if not set (fixes #534) Fix: Add default values for Drawer button icon and position (fixes #534) May 13, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

oliverfoster
oliverfoster requested changes May 14, 2024
View reviewed changes
templates/nav.hbs Outdated Show resolved Hide resolved
@swashbuck @oliverfoster
Use else instead of unless
714761d 
Co-authored-by: Oliver Foster <[email protected]>
@swashbuck swashbuck requested a review from oliverfoster May 14, 2024 17:55
oliverfoster
oliverfoster requested changes May 14, 2024
View reviewed changes
templates/nav.hbs Outdated Show resolved Hide resolved
@swashbuck swashbuck requested a review from oliverfoster May 14, 2024 19:45
guywillis
guywillis approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 58c84cb into master May 15, 2024
@oliverfoster oliverfoster deleted the issue/534 branch May 15, 2024 13:50
github-actions bot pushed a commit that referenced this pull request May 15, 2024
@semantic-release-bot
Chore(release): 6.46.9
6a0014b 
## [6.46.9](v6.46.8...v6.46.9) (2024-05-15)

### Fix

* Add default values for Drawer button icon and position (fixes #534) (#536) ([58c84cb](58c84cb)), closes [#534](#534) [#536](#536)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.46.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default values for Drawer button icon and position
4 participants
@swashbuck @oliverfoster @guywillis @cahirodoherty-learningpool