Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pageBody attribute #149

Merged
merged 2 commits into from
May 15, 2023
Merged

Added pageBody attribute #149

merged 2 commits into from
May 15, 2023

Conversation

simondate
Copy link
Member

@simondate simondate commented Apr 26, 2023 •
edited by oliverfoster
Loading

Fixes #148

Fix

  • Changed template to use pageBody if available

@simondate
Copy link
Member Author

Before the fix.

chrome_zXo75ZgG1m.mp4

After the fix.

chrome_CkEaWjErrE.mp4

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member

Can you try the code with amendments please? @simondate

simondate
simondate commented May 15, 2023
View reviewed changes
Copy link
Member Author

@simondate simondate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to work fine @oliverfoster , I can't approve as the creator of the PR but happy to use this version instead

@oliverfoster oliverfoster merged commit 4917ba9 into master May 15, 2023
@oliverfoster oliverfoster deleted the issue/148 branch May 15, 2023 10:54
github-actions bot pushed a commit that referenced this pull request May 15, 2023
@semantic-release-bot
Chore(release): 6.3.8 [skip ci]
0401667 
## [6.3.8](v6.3.7...v6.3.8) (2023-05-15)

### Fix

* Added pageBody attribute (#149) ([4917ba9](4917ba9)), closes [#149](#149)
@github-actions
Copy link

🎉 This PR is included in version 6.3.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@simondate simondate

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pageBody text doesn't show in submenus
4 participants
@simondate @oliverfoster @cahirodoherty-learningpool @ethan-lp