Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude hidden items from items count ARIA #164

Closed
kirsty-hames opened this issue Sep 12, 2023 · 1 comment · Fixed by #170
Closed

Exclude hidden items from items count ARIA #164

kirsty-hames opened this issue Sep 12, 2023 · 1 comment · Fixed by #170
Assignees
@joe-allen-89
Labels
accessibility bug released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

The item count ARIA introduced in this PR includes all model items to set the _totalChild value.

Expected behaviour

I'd expect hidden items, "_isHidden": true, to be excluded from the item count so _totalChild reflects the number of items rendered in the menu view.

Just FYI, there's currently a related PR open which updates the item count ARIA for grouped items.
@joe-allen-89 joe-allen-89 self-assigned this Oct 18, 2023
@joe-allen-89 joe-allen-89 moved this from New to Assigned in adapt_framework: The TODO Board Oct 18, 2023
@joe-allen-89 joe-allen-89 mentioned this issue Oct 19, 2023
Merged
@joe-allen-89 joe-allen-89 linked a pull request Oct 19, 2023 that will close this issue
Fix: Exclude hidden items from items count ARIA (fixes #164) #170
Merged
@joe-allen-89 joe-allen-89 moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Oct 19, 2023
kirsty-hames pushed a commit that referenced this issue Oct 30, 2023
@joe-allen-89
Fix: Exclude hidden items from items count ARIA (fixes #164) (#170)
2a09783 
* Fix: Exclude hidden items from items count ARIA

* Fix: BoxMenuGroupView updated to exclude hidden children.
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 30, 2023
github-actions bot pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
Chore(release): 6.4.1 [skip ci]
67e6a55 
## [6.4.1](v6.4.0...v6.4.1) (2023-10-30)

### Fix

* Exclude hidden items from items count ARIA (fixes #164) (#170) ([2a09783](2a09783)), closes [#164](#164) [#170](#170)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Exclude hidden items from items count ARIA (fixes #164) adaptlearning/adapt-contrib-boxMenu
2 participants
@kirsty-hames @joe-allen-89