Fix: Update item count ARIA for grouped items (fixes #160)

[kirsty-hames]

Fixes #160

Item count is relevant to it's parent container (all items within Boxmenu as default, or items contained within a parent group).

Test PR
Configure your course to use the Boxmenu grouping (see example for ref).

Inspect 'View' Button aria-label and item count should be relevant to the Boxmenu group set up.
e.g. item index in group + total items in group

[swashbuck]

@kirsty-hames Thanks for taking a look at this one.

This may be intended behavior, but here my test case and what I'm seeing:

• I'm using the standard sandbox build (Presentation Components, Question Components, and Assessment topics)
• I've put Presentation and Question topics into a group (co-000). The "view" buttons here correctly display "1 of 2" and "2 of 2"
• Assessment is ungrouped. The weird thing is that the "view" button is displaying "Item 2 of 2." Is this because the co-000 group is considered an item? Is this how we want it to work (I don't have any better ideas atm lol)?

[kirsty-hames]

@kirsty-hames Thanks for taking a look at this one.

This may be intended behavior, but here my test case and what I'm seeing:

• I'm using the standard sandbox build (Presentation Components, Question Components, and Assessment topics)
• I've put Presentation and Question topics into a group (co-000). The "view" buttons here correctly display "1 of 2" and "2 of 2"
• Assessment is ungrouped. The weird thing is that the "view" button is displaying "Item 2 of 2." Is this because the co-000 group is considered an item? Is this how we want it to work (I don't have any better ideas atm lol)?

Hey @swashbuck, yep, groups are considered an item and this is the behaviour I'd expect. I think most use cases, all items would be assigned to a group or no groups enabled (as standard Boxmenu setup). In the instance not all items are assigned a group (as per your test case), I'm not sure what an alternative would be. The current aria reflects the menu item structure at least.

[kirsty-hames]

Thanks @swashbuck. I've applied your suggestion in a4cbeda

[swashbuck]

👍

[joe-allen-89]

Working as expected with FW v5.31.23

[github-actions]

🎉 This PR is included in version 6.3.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀