Update joust.conf to kill all joust processes when a stop command is … #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issued Change stopsignal to KILL from default TERM because python apparently ignores the TERM. This makes the stop immediate instead of delayed while supervisor waits on the TERM. Also, stopping/killing the entire process group (all the joust (pyparty processes) rather than just the parent process. Apparently a known issue with python, per the supervisor man page: "when resorting to send SIGKILL to the program to terminate it send it to its whole process group instead, taking care of its children as well, useful e.g with Python programs using multiprocessing."
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issued
Change stopsignal to KILL from default TERM because python apparently ignores the TERM. This makes the stop immediate instead of delayed while supervisor waits on the TERM.
Also, stopping/killing the entire process group (all the joust (pyparty processes) rather than just the parent process. Apparently a known issue with python, per the supervisor man page: "when resorting to send SIGKILL to the program to terminate it send it to its whole process group instead, taking care of its children as well, useful e.g with Python programs using multiprocessing."