Add a sorted set container type #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 29, 2015 09:58
This implements IndexedKeyValueStore Bug: T99152
This prevents collisions between queues containing elements with the same key.
| @@ -6,7 +6,19 @@ | |||
| use PHPQueue\Interfaces\FifoQueueStore; | |||
There was a problem hiding this comment.
Nice!! Just a few minor comments:
- Maybe be a little more consistent with terminology? For example, in the PHPdoc on line 11, you talk about a key-value store, but in the exception messages in push() you use "zset".
- A good approach might be to mention in the PHPdoc that this is backed by a Redis zset... and also maybe note that that's the origin of the term "score".
- A bit more inline comments explaining the why of some stuff would be cool, I think... Since I'm not looking at the whole codebase I'm not sure what's obvious and what's not, but... it does feel like there could be more inline explanations.
There was a problem hiding this comment.
Good point about "score", I'm hiding that detail in favor of "order key" which should be more descriptive.
added 2 commits
June 3, 2015 18:09
Change-Id: I1e7f27103bcdbf646a1bed9dda4f066090462359
Change-Id: I94c886cd6e361128069a6c2bd6b8da533310a2af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements IndexedKeyValueStore
Bug: https://phabricator.wikimedia.org/T99152