Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom processor with two arguments #186

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Custom processor with two arguments #186

merged 7 commits into from
Feb 14, 2024

Conversation

ITDancer13
Copy link
Contributor

Extend custom processors: Support callbacks with two arguments:

  1. Content to be processed
  2. Filename which is processed

@ITDancer13 ITDancer13 mentioned this pull request Feb 7, 2024
Closed
adamreisnz
adamreisnz requested changes Feb 12, 2024
View reviewed changes
Copy link
Owner

@adamreisnz adamreisnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggested tweaks

lib/process-file.spec.js Outdated Show resolved Hide resolved
lib/process-file.spec.js Outdated Show resolved Hide resolved
lib/helpers/run-processors.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@adamreisnz adamreisnz merged commit e90c51f into adamreisnz:main Feb 14, 2024
@adamreisnz
Copy link
Owner

adamreisnz commented Feb 14, 2024 •
edited
Loading

Thank you, I will include this in 8.0.0 and also convert to ESM module at the same time (in the coming days) 👍🏼

@adamreisnz
Copy link
Owner

This has been released in 7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreisnz adamreisnz adamreisnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ITDancer13 @adamreisnz @pasoma2015