WIP comma-separated region version 2 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampauls
force-pushed
the
no_weird_trailing_commas
branch
from
ebfd546 to
0edf5a2
Compare
… in a comma-separated region.
adampauls
force-pushed
the
comma_separated_region_2
branch
from
25162df to
88a33cd
Compare
adampauls
force-pushed
the
no_weird_trailing_commas
branch
from
0edf5a2 to
8a09cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing down a flag, add a bit to regions to say if we are… in a comma-separated region.