-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dokka to 1.9.0 #117
Comments
Looks like there's a breaking change as mentioned in the release notes:
Setting the version to dokkatoo {
versions.jetbrainsDokka = "1.9.0"
} Results in the following error:
View stacktrace
|
Yes, Dokkatoo needs an update! If you (or anyone else) would like to get started with a PR, please make one - else I'll make a minimal one first. Thank you for the report on the problems with the changed dependencies. Those dependencies are added by default in this bit of code: dokkatoo/modules/dokkatoo-plugin/src/main/kotlin/formats/DokkatooFormatPlugin.kt Lines 151 to 173 in b1ca20c
If anyone needs to update Dokkatoo to use Dokka 1.9 ASAP then you can try manually excluding those discontinued Dokka dependencies from the affected Configurations. Just don't ask me what the Gradle buildscript logic is for excluding dependencies, I can't remember what it is! |
This spaghetti of code appears to work for now: dokkatoo.versions.jetbrainsDokka = "1.9.0"
configurations.matching { it.name.startsWith("dokkatooPlugin") }.configureEach {
listOf(
"org.jetbrains.dokka" to "dokka-analysis",
"org.jetbrains.dokka" to "kotlin-analysis-intellij",
"org.jetbrains.dokka" to "kotlin-analysis-compiler"
).forEach { (group, module) ->
exclude(group = group, module = module)
}
dependencies.add(
name, // From Configuration#getName
dokkatoo.versions.jetbrainsDokka.map { "org.jetbrains.dokka:analysis-kotlin-descriptors:$it" }
)
} I'll see if I can make a PR :) |
* Move Kotlin Analysis dependencies to new single dependency (analysis-kotlin-descriptors) * Dependency updates: * Update Kotlin from 1.8.20 to 1.9.0 * Update Dokka from 1.8.20 to 1.9.0 * Update Kotlin Serialization from 1.5.1 to 1.6.0 * Update internal Dokkatoo from 1.5.0 to 1.6.0 Resolves adamko-dev#117
* Update Dokka to 1.9.0 * Move Kotlin Analysis dependencies to new single dependency (analysis-kotlin-descriptors) * Dependency updates: * Update Kotlin from 1.8.20 to 1.9.0 * Update Dokka from 1.8.20 to 1.9.0 * Update Kotlin Serialization from 1.5.1 to 1.6.0 * Update internal Dokkatoo from 1.5.0 to 1.6.0 Resolves #117 * remove overridden Dokka version in `:docs` * update example projects * update integration test projects --------- Co-authored-by: Adam <[email protected]>
Dokka 1.9.0 was just released - I presume the Dokka version can be updated as per #88 but there might be breaking changes :P
The text was updated successfully, but these errors were encountered: